CI workflow for python package publishing #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
changed the title
Noarkhh
force-pushed
the
erlang-release-download
branch
from
d905da0 to
6d29e39
Compare
mat-hek
reviewed
Sep 23, 2025
Comment on lines
232
to
254
| Path.join(base_dir, "bundlex*/priv/shared/precompiled/*/lib") | ||
| |> Path.wildcard() | ||
| |> Enum.map(fn lib_dir -> | ||
| File.ls!(lib_dir) | ||
| |> Enum.group_by(&(String.split(&1, ".") |> List.first())) | ||
| |> Enum.each(fn {_lib_name, libs} -> | ||
| lib_to_symlink_to = | ||
| Enum.max_by(libs, &String.length/1) | ||
|
|
||
| libs | ||
| |> Enum.filter(&(&1 != lib_to_symlink_to)) | ||
| |> Enum.map(fn lib_to_replace -> | ||
| lib_to_replace_path = | ||
| Path.join(lib_dir, lib_to_replace) | ||
|
|
||
| File.rm_rf!(lib_to_replace_path) | ||
| File.ln_s!(lib_to_symlink_to, lib_to_replace_path) | ||
| end) | ||
| end) | ||
| end) |
Noarkhh
force-pushed
the
erlang-release-download
branch
3 times, most recently
from
92092ce to
2e5e322
Compare
varsill
reviewed
Sep 24, 2025
python/src/boombox/boombox.py
Outdated
| ) | ||
|
|
||
| self._download_elixir_boombox_release() | ||
| release_path = os.path.join(self._data_dir, "bin", "server") |
There was a problem hiding this comment.
[NIT] Let's wrap that os.path.join(self._data_dir, "bin", "server") into some kind of a helper function, I think we use it in several places
python/src/boombox/boombox.py
Outdated
| download_url, filename=tarball_path, reporthook=t.update_to | ||
| ) | ||
|
|
||
| print("Download complete. Extracting...") |
There was a problem hiding this comment.
I would use logger from the logging module instead of print
mat-hek
approved these changes
Sep 24, 2025
Noarkhh
force-pushed
the
erlang-release-download
branch
from
0ae50c3 to
0f55603
Compare
Noarkhh
force-pushed
the
erlang-release-download
branch
from
0f55603 to
8ffbeb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
CI workflow
The new jobs are:
Fixed and improved symlink restoring
The restored symlinks now point to correct locations. The symlinks between versioned shared objects of the same library (e.g. libvpx.dylib -> libvpx.11.dylib) are now restored too.
Downloading the elixir Boombox release
Once the Boombox class is instantiated a check is performed if the elixir release of boombox is present on the user's computer (in a default location defined with
platformdirspackage). If not, the release is downloaded from a github release matching the version of the python package.